Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/synapse-interface/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"lint": "next lint",
"cypress:run": "echo 'No cypress tests defined.'",
"test:coverage": "echo 'No tests defined.'",
"test:rpc": "node --test utils/providers/TransportAwareJsonRpcProvider.test.cjs",
"test:rpc": "node --test utils/providers/TransportAwareJsonRpcProvider.test.cjs utils/createTransports.test.cjs",
"lint:fix": "npm run lint -- --fix",
"lint:check": "eslint . --max-warnings=0",
"lint:find-string-literals": "npx eslint -c .eslintrc-i18n.js './**/*.{js,jsx,ts,tsx}'",
Expand Down
69 changes: 69 additions & 0 deletions packages/synapse-interface/utils/createTransports.test.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
const assert = require('node:assert/strict')
const fs = require('node:fs')
const path = require('node:path')
const test = require('node:test')
const vm = require('node:vm')
const ts = require('typescript')
const { extractRpcUrls } = require('@wagmi/core')
const { arbitrum, mainnet } = require('@wagmi/core/chains')
const { HttpConnection } = require('@walletconnect/jsonrpc-http-connection')

const chains = [arbitrum, mainnet]
const chainConfig = Object.fromEntries(
chains.map((chain) => [
chain.id,
{
rpcUrls: {
primary: chain.rpcUrls.default.http[0],
fallback: `https://fallback.example/${chain.id}`,
},
},
])
)
const source = fs.readFileSync(
path.join(__dirname, 'createTransports.ts'),
'utf8'
)
const compiled = ts.transpileModule(source, {
compilerOptions: { module: ts.ModuleKind.CommonJS },
}).outputText

function loadTransports(origin) {
const context = {
exports: {},
URL,
require: (id) =>
id === '@/constants/chains'
? { CHAINS_BY_ID: chainConfig }
: require(id),
}
if (origin) context.window = { location: { origin } }
vm.runInNewContext(compiled, context)

Check failure on line 41 in packages/synapse-interface/utils/createTransports.test.cjs

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Make sure that this dynamic injection or execution of code is safe.

See more on https://sonarcloud.io/project/issues?id=synapsecns_sanguine&issues=AaDVqyyL4j2IsehXYBui&open=AaDVqyyL4j2IsehXYBui&pullRequest=4140
return context.exports.createTransports(chains)
}

for (const origin of [
'https://bridge.synapseprotocol.com',
'https://preview.example',
'http://localhost:3000',
]) {
test(`WalletConnect accepts extracted RPC URLs on ${origin}`, () => {
const transports = loadTransports(origin)
for (const chain of chains) {
// Exercise the same extraction and URL validation as the connector.
const urls = extractRpcUrls({ chain, transports })
assert.deepEqual(Array.from(urls), [
`${origin}/api/rpc/${chain.id}`,
chainConfig[chain.id].rpcUrls.primary,
chainConfig[chain.id].rpcUrls.fallback,
])
assert.doesNotThrow(() => new HttpConnection(urls[0]))
}
})
}

test('transport configuration remains safe to load during SSR', () => {
const transports = loadTransports()
const urls = extractRpcUrls({ chain: arbitrum, transports })
assert.equal(urls[0], '/api/rpc/42161')
})
9 changes: 8 additions & 1 deletion packages/synapse-interface/utils/createTransports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,16 @@ type Transports = Record<Chain['id'], Transport>
export const createTransports = (chains: Chain[]): Transports => {
return chains.reduce<Transports>((acc, chain) => {
const synapseChain = CHAINS_BY_ID[chain.id]
const proxyPath = `/api/rpc/${chain.id}`
// WalletConnect extracts this URL from the transport and requires HTTP(S).
// Resolve against the current origin so previews and localhost use their proxy.
const proxyUrl =
typeof window === 'undefined'
? proxyPath
: new URL(proxyPath, window.location.origin).href

const rpcUrls = [
`/api/rpc/${chain.id}`,
proxyUrl,
synapseChain.rpcUrls.primary,
synapseChain.rpcUrls.fallback,
]
Expand Down
Loading