Repository navigation
Fix stale bridge quote refresh lifecycle - #4146
ChiTimesChi wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: synapsecns/sanguine/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4146 +/- ##
=============================================
Coverage 57.57648% 57.57648%
=============================================
Files 147 147
Lines 4217 4217
Branches 809 809
=============================================
Hits 2428 2428
Misses 1699 1699
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Deploying sanguine-fe with
|
| Latest commit: |
724392c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://112ae0d5.sanguine-fe.pages.dev |
| Branch Preview URL: | https://codex-stale-quote-refresh.sanguine-fe.pages.dev |
Bundle ReportChanges will increase total bundle size by 62.1kB (0.18%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sdk-router-@synapsecns/sdk-router-cjsAssets Changed:
view changes for bundle: synapse-interface-server-cjsAssets Changed:
Files in
view changes for bundle: synapse-interface-edge-server-array-pushAssets Changed:
view changes for bundle: sdk-router-@synapsecns/sdk-router-esmAssets Changed:
view changes for bundle: synapse-interface-client-array-pushAssets Changed:
|
Description
Stale bridge quotes can retain mouse listeners after replacement or disabling, causing obsolete callbacks to issue extra quote requests. Remove listeners during cleanup, use the latest callback and enabled state, and replace the repeating interval with guarded timeouts that rearm after a refresh settles.
Keep the in-flight guard local to each quote cycle. A never-settling older refresh cannot block a replacement quote from becoming stale or refreshing, and an older completion cannot clear the replacement cycle's pending state. The bridge page pauses automatic refresh while loading.
Additional context
findLastin the regression tests and the cycle-ownership issue identified in the review of Reduce HyperCore SYN quote RPC load #4144.Validation
git diff --checkpassed.70eb6b6: synapse-interface preview link