Skip to content

Perf: Hoist ToList() out of loops in CartesianChartArea.UpdateSBS and GetTotalWidth #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PaulAndersonS wants to merge 3 commits into from
Closed

Perf: Hoist ToList() out of loops in CartesianChartArea.UpdateSBS and GetTotalWidth #373

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f28d940
Perf: Hoist ToList() out of loops in CartesianChartArea
PaulAndersonS May 26, 2026
572ff66
Merge branch 'main' into paulandersons/perf-optimize-chart-bindable-l…
SaiyathAliFathima Jun 6, 2026
93a56cf
Update CartesianChartArea.cs
SaiyathAliFathima Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions maui/tests/Syncfusion.Maui.Toolkit.UnitTest/Chart/Features/ChartAreaUnitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,33 @@ public void GetTotalWidth_Test()
}


[Fact]
public void UpdateSBS_WithMultipleSeriesGroups_ShouldComputeSbsInfo()
{
var chart = new SfCartesianChart();
var series1 = new ColumnSeries() { Width = 0.8 };
var series2 = new ColumnSeries() { Width = 0.8 };
var series3 = new ColumnSeries() { Width = 0.6 };

var area = new CartesianChartArea(chart)
{
SideBySideSeriesPosition = new Dictionary<object, List<CartesianSeries>>
{
{ 0, new List<CartesianSeries> { series1, series2 } },
{ 1, new List<CartesianSeries> { series3 } }
},
EnableSideBySideSeriesPlacement = false,
SideBySideMinWidth = 1
};

area.UpdateSBS();

// Verify SbsInfo is set on each series
Assert.NotEqual(DoubleRange.Empty, series1.SbsInfo);
Assert.NotEqual(DoubleRange.Empty, series2.SbsInfo);
Assert.NotEqual(DoubleRange.Empty, series3.SbsInfo);
}

[Fact]
public void AddAxes_ShouldSetParentAndArea()
{
Expand Down