Completed CollectSliceIntoStringSlice implementation with unit tests - #13
Merged
Merged
Conversation
synesissoftware
self-requested a review
November 26, 2025 20:09
synesissoftware
requested changes
Nov 26, 2025
synesissoftware
left a comment
synesissoftware
left a comment
Owner
There was a problem hiding this comment.
Please change variable names. Otherwise, looks good.
|
|
||
| result_slice := make([]string, len(input_slice)) | ||
|
|
||
| for i, s := range input_slice { |
Owner
There was a problem hiding this comment.
Choice of local variable names is a bit misleading. Suggest instead you replace s with t and replace a with s
Owner
|
Also, please add a line into README.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed CollectSliceIntoStringSlice implementation with unit tests