SC-3: delta-transfer algorithm (rolling checksum + block matching) - #4
Merged
Merged
Conversation
Rolling weak checksum + MD5 strong checksum, block signature generation, and delta generation/application with weak-checksum collisions disambiguated by strong checksum. Signature bundles block size with checksums so generation/application can't drift out of sync. Self-review found a dead assignment and, more importantly, that the collision-disambiguation path had no test exercising it — added a hand-constructed genuine Adler-32 collision to prove it actually works in both directions. 58 tests, including a 10-case round-trip suite. Clean on Windows and Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolling weak checksum + MD5 strong checksum, block signature generation, and delta generation/application with weak-checksum collisions disambiguated by strong checksum. Signature bundles block size with checksums so generation/application can't drift out of sync.
Self-review found a dead assignment and, more importantly, that the collision-disambiguation path had no test exercising it — added a hand-constructed genuine Adler-32 collision to prove it actually works in both directions.
58 tests, including a 10-case round-trip suite. Clean on Windows and Linux.