Repository navigation
SC-6: rsync daemon/server mode - #8
Merged
Merged
Conversation
rsyncd.conf parsing (modules, read-only, list, exclude, auth users, secrets file, max connections, defaults, comments, line continuation), rsync:// URL parsing, real @rsyncd greeting/handshake, module listing with list=false hiding, MD4 challenge-response auth verified against rsync's actual source (secret-then-challenge, no seed byte, unpadded base64 - proven via raw wire-byte inspection that passwords never cross the wire). Module access control (read-only blocks uploads, exclude reuses sync.CompileRules). Wired into existing pipeline.Sender/Receiver, no duplicated transfer logic. --daemon --config --port CLI mode with real TCP listener. Two real bugs found: DialGreeting had client/server speaking order reversed (deadlocked over io.Pipe, would've been masked by real TCP's OS buffering); Serve's per-connection goroutine had no panic recovery, so one bad connection could crash the whole daemon - fixed, plus added bounded line-length reads to close a memory-exhaustion vector on unauthenticated input. Scope: classic MD4 only (no digest negotiation), exact-match auth users, no secrets-file permission checking, max connections parsed but unenforced, exclude on downloads only. Transfer after handshake still uses gob, not real rsync wire format - same boundary as SSH transport. Clean on native Windows and cross-compiled Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rsyncd.conf parsing (modules, read-only, list, exclude, auth users, secrets file, max connections, defaults, comments, line continuation), rsync:// URL parsing, real @rsyncd greeting/handshake, module listing with list=false hiding, MD4 challenge-response auth verified against rsync's actual source (secret-then-challenge, no seed byte, unpadded base64 - proven via raw wire-byte inspection that passwords never cross the wire). Module access control (read-only blocks uploads, exclude reuses sync.CompileRules). Wired into existing pipeline.Sender/Receiver, no duplicated transfer logic. --daemon --config --port CLI mode with real TCP listener.
Two real bugs found: DialGreeting had client/server speaking order reversed (deadlocked over io.Pipe, would've been masked by real TCP's OS buffering); Serve's per-connection goroutine had no panic recovery, so one bad connection could crash the whole daemon - fixed, plus added bounded line-length reads to close a memory-exhaustion vector on unauthenticated input.
Scope: classic MD4 only (no digest negotiation), exact-match auth users, no secrets-file permission checking, max connections parsed but unenforced, exclude on downloads only. Transfer after handshake still uses gob, not real rsync wire format - same boundary as SSH transport.
Clean on native Windows and cross-compiled Linux.