Security hardening for open-source release#2
Merged
Conversation
🔍 Onit Code Review❌ API Error (401): {"type":"error","error":{"type":"authentication_error","message":"x-api-key header is required"},"request_id":"req_011CcCH6k2NbsAxvwAzAcMTf"} Automated review · 66a43e0 |
- Gate printCurlRequest and its Perplexity call-site behind #if DEBUG so Bearer tokens no longer reach Release logs - Stop tracking the Developer ID provisioning profile; ignore *.provisionprofile and *.mobileprovision - Add NSAppleEventsUsageDescription for the Apple Events automation entitlement - Remove the onitbot resolver and code-review GitHub workflows — they reference a private repo (synth-inc/onitbot) and use secrets, so they don't belong in a public repo
Niduank
force-pushed
the
fix/security-hardening
branch
from
66a43e0 to
3a0d97e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-open-source security hardening (audit findings #1, #3, #8, #10):
printCurlRequestand its Perplexity call-site behind#if DEBUGso Bearer tokens no longer reach Release logs; remove a strayprint("here").Onit_Developer_ID.provisionprofileand ignore*.provisionprofile/*.mobileprovision. The file stays on disk for local builds.NSAppleEventsUsageDescriptionfor the Apple Events automation entitlement.synth-inc/onitbot) and use secrets, so they don't belong in a public repo.Note: the Developer ID provisioning profile was also removed from history — the single root commit was rewritten and
origin/mainforce-pushed accordingly.