Conversation
Update the optional native E2E gate so it can run against a local Chrome executable with the native HTML-in-Canvas feature enabled. What changed: - Launch the native Playwright project with --enable-features=CanvasDrawElement. - Add an inline empty favicon to the E2E fixture so Chrome does not emit a /favicon.ico 404 that trips the console-error gate. Verification: - PLAYWRIGHT_CHROMIUM_EXECUTABLE_PATH="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" pnpm e2e:native - pnpm e2e - pnpm typecheck
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native E2E follow-u
The optional native E2E gate now runs successfully against local Chrome when launched with the native HTML-in-Canvas feature flag.
Changes
playwright.native.config.tsto launch Chrome with:Verification
Passed:
Native E2E passed 1 native test. Fallback E2E passed 5 Chromium lifecycle tests.