test(e2e): cover ScaleToZero API + pending datapath spec - #32
Merged
Conversation
Add smoke e2e for the Phase 3 ScaleToZero API surface (installed via the chart CRDs, enforced by the validating webhook), which had no e2e coverage: reject an idleTimeout below the 10s floor, and admit a ScaleToZero ImpVM with the experimental admission warning. Control-plane only, so they run in the agent-off Kind smoke harness. Add a deliberately Pending (PIt) datapath spec documenting the wake-on-traffic flow (suspend -> frame -> resume). It cannot run until a KVM node + real Firecracker agent exist and BeforeSuite conditionally enables the agent; the traffic-injection source is an open question for first run. The runbook carries that harness work — this spec is the placeholder it will fill in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds e2e coverage for the Phase 3 ScaleToZero API surface, which had none.
Runs now (Kind smoke, agent-off — control-plane only):
idleTimeoutis below the 10s webhook floor.kubectlprints it to stderr;utils.Runcaptures it viaCombinedOutput).Dropped a defaulting assertion:
idleTimeouthas no+kubebuilder:default, so5mis a runtime-only fallback (idleTimeoutOrDefault) and is never persisted into the stored object.Pending (
PIt, labeldatapath— runs nowhere yet):no-agent=truetoday). The traffic-injection source is an open question for first run. The forthcoming e2e runner runbook carries that harness work — this spec is the placeholder it fills in.