fix(oci): tag reserved public IPs for monitor safety - #23
Merged
Conversation
…ce a failover CreateReservedPublicIP never set FreeformTags. oci-free-tier-monitor's orphan-IP cleanup only checks lifecycle_state == AVAILABLE, which a managed IP briefly reads during this controller's own detach/reattach on node failover — the monitor's scheduled scan could delete a live Service's VIP mid-reassignment. Tag every IP pivot creates with pivot.oci.io/managed: "true"; the monitor already skips anything carrying that tag regardless of lifecycle_state (syscode-labs/oci-free-tier-monitor, already fixed there).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateReservedPublicIPnever tagged the IP it createsoci-free-tier-monitor's orphan-cleanup only checkslifecycle_state == AVAILABLE, which a pivot-managed IP briefly reads mid-failover during this controller's own detach/reattach — the monitor's scheduled scan could delete a live Service's VIP at exactly the wrong momentpivot.oci.io/managed: "true"; the monitor (already fixed insyscode-labs/oci-free-tier-monitor) skips anything carrying that tag regardless of lifecycle_stateTest plan
go build ./...passesgofmtcleangolangci-lintpasses (pre-commit)