feat: support sourcing compartment-id from a Secret via env var - #25
Merged
Conversation
--compartment-id was Helm-render-time only, so a chart-based deployment could never source it from a runtime Secret (e.g. via External Secrets Operator) without baking it into a plain Helm value. Adds an OCI_COMPARTMENT_ID env var fallback for the flag, and extraEnvFrom on the chart so it can be wired to a Secret's envFrom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--compartment-idwas only settable via a Helm-render-time CLI arg — a chart-based deployment had no way to source it from a runtime Secret (e.g. External Secrets Operator) without a plain Helm value ending up in gitOCI_COMPARTMENT_IDenv var as a fallback default for the flagextraEnvFromto the chart so it can be wired toenvFrom: - secretRef: {name: ...}Test plan
go build ./...passesgofmtcleangolangci-lintpasses (pre-commit)helm lintpasseshelm templatewithextraEnvFromset rendersenvFromcorrectly, and correctly omits--compartment-idwhenoci.compartmentIdis unset