Add filter reset and clear controls#751
Merged
YukiMatsuzawa merged 8 commits intoJul 22, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a filter-reset pathway and keyword clear affordances to make peak-spot/alignment filtering easier to revert and quicker to edit.
Changes:
- Introduces a reset command in
PeakSpotNavigator*and reset methods on underlying filter models. - Adds per-keyword clear buttons (XAML) and view-model support (
ClearCommand) for keyword fields. - Propagates the reset UI into alignment spot tables (and partially into analysis peak tables).
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| src/MSDIAL5/MsdialGuiApp/ViewModel/Search/ValueFilterViewModel.cs | Adds a Reset() entry point delegating to the model reset. |
| src/MSDIAL5/MsdialGuiApp/ViewModel/Search/PeakSpotTagSearchQueryBuilderViewModel.cs | Adds a Reset() that clears tag toggles in the VM. |
| src/MSDIAL5/MsdialGuiApp/ViewModel/Search/PeakSpotNavigatorViewModel.cs | Adds ResetFiltersCommand wiring to PeakSpotNavigatorModel.ResetFilters(). |
| src/MSDIAL5/MsdialGuiApp/ViewModel/Search/PeakFilterViewModel.cs | Forces property change notifications when the underlying flag set changes. |
| src/MSDIAL5/MsdialGuiApp/ViewModel/Search/KeywordFilterViewModel.cs | Adds ClearCommand and syncs textbox content from model keyword state. |
| src/MSDIAL5/MsdialGuiApp/View/Lcms/LcmsAnalysisPeakTableView.xaml | Adds keyword clear button UI + a reset filter button. |
| src/MSDIAL5/MsdialGuiApp/View/Lcms/LcmsAlignmentSpotTableView.xaml | Adds keyword clear button UI + a reset filter button. |
| src/MSDIAL5/MsdialGuiApp/View/Lcimms/LcimmsAnalysisPeakTableView.xaml | Updates keyword binding mode; missing clear/reset UI compared to PR intent. |
| src/MSDIAL5/MsdialGuiApp/View/Lcimms/LcimmsAlignmentSpotTableView.xaml | Adds keyword clear button UI + a reset filter button. |
| src/MSDIAL5/MsdialGuiApp/View/Imms/ImmsAnalysisPeakTableView.xaml | Updates keyword binding mode; missing clear/reset UI compared to PR intent. |
| src/MSDIAL5/MsdialGuiApp/View/Imms/ImmsAlignmentSpotTableView.xaml | Adds keyword clear button UI + a reset filter button. |
| src/MSDIAL5/MsdialGuiApp/View/Gcms/GcmsAnalysisPeakTableView.xaml | Updates keyword binding mode; missing clear/reset UI compared to PR intent. |
| src/MSDIAL5/MsdialGuiApp/View/Gcms/GcmsAlignmentSpotTableView.xaml | Adds keyword clear button UI + a reset filter button. |
| src/MSDIAL5/MsdialGuiApp/View/Dims/DimsAnalysisPeakTableView.xaml | Updates keyword binding mode; missing clear/reset UI compared to PR intent. |
| src/MSDIAL5/MsdialGuiApp/View/Dims/DimsAlignmentSpotTableView.xaml | Adds keyword clear button UI + a reset filter button. |
| src/MSDIAL5/MsdialGuiApp/Model/Search/ValueFilterModel.cs | Adds Reset() restoring min/max bounds and disabling the filter. |
| src/MSDIAL5/MsdialGuiApp/Model/Search/PeakSpotTagSearchQueryBuilderModel.cs | Adds Reset() clearing all tag-search toggles. |
| src/MSDIAL5/MsdialGuiApp/Model/Search/PeakSpotNavigatorModel.cs | Adds ResetFilters() to clear all filter types back to defaults. |
| src/MSDIAL5/MsdialGuiApp/Model/Search/KeywordFilterModel.cs | Adds ClearKeywords() and property-change notification for Keywords. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
85
to
86
| <TextBox Text="{Binding Keywords.Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" | ||
| HorizontalAlignment="Stretch"/> |
Comment on lines
89
to
90
| <TextBox Text="{Binding Keywords.Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" | ||
| HorizontalAlignment="Stretch"/> |
Comment on lines
89
to
90
| <TextBox Text="{Binding Keywords.Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" | ||
| HorizontalAlignment="Stretch"/> |
Comment on lines
90
to
91
| <TextBox Text="{Binding Keywords.Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" | ||
| HorizontalAlignment="Stretch"/> |
Comment on lines
85
to
86
| <TextBox Text="{Binding Keywords.Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" | ||
| HorizontalAlignment="Stretch"/> |
Comment on lines
89
to
90
| <TextBox Text="{Binding Keywords.Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" | ||
| HorizontalAlignment="Stretch"/> |
Comment on lines
89
to
90
| <TextBox Text="{Binding Keywords.Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" | ||
| HorizontalAlignment="Stretch"/> |
Comment on lines
90
to
91
| <TextBox Text="{Binding Keywords.Value, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}" | ||
| HorizontalAlignment="Stretch"/> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…s://github.com/systemsomicslab/MsdialWorkbench into copilot/yukimatsuzawa-filter-ui-clear-controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a global filter reset action and per-textbox clear affordances for the peak spot and alignment tables.
This keeps the filter UI consistent across the analysis and alignment views while letting users clear individual keyword fields without manually deleting text. The reset path also clears the underlying filter state so checkbox, range, and tag selections all return to their default values together.
Changes