Skip to content

Upgrade civix-generated code to civix format version 25.01.1#4

Merged
jensschuppe merged 1 commit into
masterfrom
civix-upgrade
Jul 29, 2025
Merged

Upgrade civix-generated code to civix format version 25.01.1#4
jensschuppe merged 1 commit into
masterfrom
civix-upgrade

Conversation

@bjendres
Copy link
Copy Markdown
Member

@bjendres bjendres commented Jul 28, 2025

with the civix upgrade I think we can release a 1.0.0

systopia-reference: 29820

@bjendres bjendres requested review from dontub and jensschuppe and removed request for jensschuppe July 28, 2025 18:32
@bjendres
Copy link
Copy Markdown
Member Author

@dontub Could you have a brief look if you can see anything critical in the civix upgrade? Otherwise I would release it as 1.0.0.

@bjendres bjendres assigned bjendres and dontub and unassigned bjendres Jul 28, 2025
Copy link
Copy Markdown

@dontub dontub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but LGTM.

Copy link
Copy Markdown

@dontub dontub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phpstan configuration needs to bu updated so DB/DataObject.php can be found.

@jensschuppe
Copy link
Copy Markdown
Collaborator

Re-did the civix upgrade without updating to Entity Framework v2 which involves some adjustments, see follow-up #5.

@jensschuppe jensschuppe changed the title civix upgrade Upgrade civix-generated code to civix format version 25.01.1 Jul 29, 2025
@jensschuppe jensschuppe merged commit 984cdd6 into master Jul 29, 2025
7 checks passed
@jensschuppe jensschuppe deleted the civix-upgrade branch July 29, 2025 10:14
@jensschuppe jensschuppe added enhancement New feature or request status:fixed The issue has been resolved (usually by committing/merging code). labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request status:fixed The issue has been resolved (usually by committing/merging code).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants