Repository navigation
Parse namespaced/single-space/arg-gapped entries; add 5 CLIs + ~40 fixtures - #7
Merged
Merged
Conversation
…xtures - pipe-separated aliases may be namespaced (firebase mcp|experimental:mcp) - single-space name/desc separator inside known sections (istioctl create-remote-secret overflowing the cobra name column) - prefixed entries skip placeholder args before the desc gap (wrangler d1 create <name> Creates ...) - skipArgs no longer bails after multi-word bracket groups consumed their trailing space (glab ci retry [<job-id | job-name>]) - deeper-indented bare tokens merge into the previous description instead of becoming entries - new captured CLIs: tofu, istioctl, pack, supabase, firebase (+NOTICE) - ~40 new nested fixture rows (doctl apps/kubernetes, argocd app/proj, glab mr/ci/release/issue/repo/auth, pulumi stack/config/plugin, flux create/get/reconcile, eksctl create/get, minikube addons/image, vercel env/teams, wrangler kv/r2/d1/pages, netlify env/functions, railway environment, hatch env/dep, pdm venv/python, meson wrap, rye toolchain/tools, stripe customers, hcloud server, supabase functions, firebase emulators) Co-Authored-By: syumai <syumai@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…ures MPL-2.0 is file-level copyleft — weaker than GPL but still copyleft — so verbatim help output should not be committed. Both CLIs now use hand-written fixtures in the same format, like the GPL/LGPL/Artistic entries. NOTICE.md updated: sops and tofu moved to the synthetic table and the policy text now names MPL explicitly. Co-Authored-By: syumai <syumai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
More parser coverage plus the largest fixture batch yet: 5 new CLIs (tofu, istioctl, pack, supabase, firebase) and ~45 nested fixtures, all
okintestdata/help/manifest.tsv. Also a licensing fix: sops and tofu are MPL-2.0 (file-level copyleft), so their fixtures are hand-written synthetics, not verbatim captures.Parser changes in
internal/helptext/parse.go:looksLikeSubPath(n)— namespaceda:bnames are valid in pipe-separated alias lists, so firebase'smcp|experimental:mcpentry parses instead of flushing the whole Commands section.relaxedEntry— inside a known commands section only, acceptname + single space + CapitalizedDesc. Needed for cobra layouts where an overlong name overflows the padded column (istioctlcreate-remote-secret Create a secret ...).prefixedEntrynow runsskipArgs(rest)before giving up, sowrangler d1 create <name> Creates ...collects the group (wrangler d1 went 3 → 9 entries).skipArgsno longer bails whenj == 0after a multi-word bracket group ([<job-id | job-name>]) consumed its trailing separator space (glabretry,trigger,viewwere dropped).directorywrapping a firebase description) is absorbed into the previous entry's description instead of becoming a bogus entry.buildin yarn) no longer suppresses theyarn-prefixed group.New manifest rows (~48): root rows for tofu/istioctl/pack/supabase/firebase plus nested
doctl apps|kubernetes,argocd app|proj,glab mr|ci|release|issue|repo|auth,pulumi stack|config|plugin,flux create|get|reconcile,eksctl create|get,minikube addons|image,vercel env|teams,wrangler kv|r2|d1|pages,netlify env|functions,railway environment,hatch env|dep,pdm venv|python,meson wrap,rye toolchain|tools,stripe customers,hcloud server,supabase functions,firebase emulators. New captured fixtures are all permissively licensed and listed intestdata/help/NOTICE.md, which now also states the policy explicitly treats MPL like GPL (synthetic only).Link to Devin session: https://app.devin.ai/sessions/6b27c26293e1466cb4b3f495d9cf77ea
Open in Devin Desktop: https://app.devin.ai/desktop/session/6b27c26293e1466cb4b3f495d9cf77ea?variant=devin
Requested by: @syumai