feat(nix): Add a NixOS module - #115
Open
CrumblyLiquid wants to merge 1 commit into
Open
CrumblyLiquid wants to merge 1 commit into
CrumblyLiquid wants to merge 1 commit into
Conversation
Owner
|
hi! it loos good, do you want to move it to ready to review? |
Author
|
The systemd service config could probably be fine-tuned more but I don't have the time to look into that right now. If you think this is good enough then feel free to merge it. I've been using it for a bit now without issues so at least it works :D |
CrumblyLiquid
marked this pull request as ready for review
June 4, 2026 15:53
|
Can we upstream this to Nixpkgs? I'd be happy to cherry-pick it into my PR for Nixpkgs here (NixOS/nixpkgs#559612), and attribute a Co-authored-by to you @CrumblyLiquid? I think the module looks good as it is, and the systemd service looks very good. We just need to upstream it. |
Author
|
Sure, go for it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
module.nixfile with the description ofservices.korrosyncconfiguration.If enabled it creates a
korrosyncsystemd service.It is configured with some hardening options (see
systemd-analyze security korrosync.service).In some ways it might be too restricting (such as setting
umaskto0077- forcing all created files/directories to be accessible only by the configured user)