Improve coverage, fix CLI KOReader passwords, and harden fork CI - #129
Open
canardleteer wants to merge 6 commits into
Open
canardleteer wants to merge 6 commits into
canardleteer wants to merge 6 commits into
Conversation
Extract CLI helpers from main for unit testing, cover error and serialization paths, and make logging init idempotent so run_server can be exercised more than once in-process.
KOReader sends md5(password) for registration and x-auth-key; CLI user create/reset now apply the same preprocessing before Argon2.
…_test Update open Renovate crate PRs to latest stable versions.
Skip release-plz, CD asset uploads, and Docker Hub pushes on forks by gating those jobs on github.repository == szaffarano/korrosync.
Apply the open Renovate GitHub Actions upgrades to latest major versions.
Pin rustup to stable with rustfmt, clippy, rust-src, rust-analyzer, and llvm-tools-preview so local and CI toolchains stay aligned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main, adding error/serialization unit tests, and covering graceful server shutdown (#17)user create/user reset-passwordso the password is MD5-hashed the same way KOReader’s sync client does, then stored with Argon2 (CLI-created users with a plain password could not authenticate from KOReader)init_loggingidempotent viatry_initsorun_servercan be invoked more than once in-process (e.g. tests)github.repository == 'szaffarano/korrosync'so forks do not publishrust-toolchain.tomlpinningstablewith rustfmt, clippy, rust-src, rust-analyzer, and llvm-tools-previewTest plan
cargo testandcargo clippy -- -D warningslocallycargo machetereports no unused dependenciesrustup show/rustc --versionpick up the reporust-toolchain.tomluser create -u alice -p secret, then authenticate from KOReader (or withx-auth-key= MD5 ofsecret)user reset-passwordonce after this change