fix(sidecar): expose gitSha/bootTs/otel in /healthz — unblocks all open PRs (Doctrine v11)#109
Merged
Merged
Conversation
The version.py module (GIT_SHA, GIT_SHA_SHORT, BOOT_TS) and telemetry.otel_active() already existed, but the /healthz handler never surfaced them. This left tests/test_telemetry_and_health.py::test_healthz_includes_git_sha_and_otel_flag failing on main, which blocked every open amaru PR's required 'Python sidecar — existing chakra tests' check. Additive, zero-bandaid: only adds 4 keys to the healthz JSON body, reusing the existing resolved values. No behavior change to chakras/scheduler/receipts. Verified in a clean CI-equivalent venv (.[dev], no otel): 53 passed, 1 skipped. Doctrine v11 (749/14/163 LOCKED). SLSA L1. Sign: Yachay. Perplexity Computer Agent. Signed-off-by: stephenlutar2-hash <yachay@szlholdings.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundational fix — unblocks all open amaru PRs
Problem
tests/test_telemetry_and_health.py::test_healthz_includes_git_sha_and_otel_flagfails onmain. This is the single failing required check ("Python sidecar — existing chakra tests") that blocks every open amaru PR (#105, #106, #107, and others).The
sidecar/src/amaru/version.pymodule already resolvesGIT_SHA,GIT_SHA_SHORT,BOOT_TS, andtelemetry.otel_active()already exists — but the/healthzhandler inapp.pynever surfaced them. The test expectsgitSha,gitShaShort,bootTs, andotelin the body.Fix
Adds 4 keys to the
/healthzJSON body, reusing the already-resolved values. Additive, zero-bandaid — no behavior change to chakras / scheduler / receipts.Verification
Reproduced the exact CI env (
pip install -e ".[dev]", no opentelemetry) in a clean venv:test_healthz_includes_git_sha_and_otel_flagFAILEDtests/suite greenDoctrine
Doctrine v11 (749/14/163 LOCKED). SLSA L1 (honest). No doctrine bump.
Sign: Yachay. Perplexity Computer Agent.