Skip to content

fix(sidecar): expose gitSha/bootTs/otel in /healthz — unblocks all open PRs (Doctrine v11)#109

Merged
stephenlutar2-hash merged 1 commit into
mainfrom
fix/healthz-gitsha-otel
Jun 1, 2026
Merged

fix(sidecar): expose gitSha/bootTs/otel in /healthz — unblocks all open PRs (Doctrine v11)#109
stephenlutar2-hash merged 1 commit into
mainfrom
fix/healthz-gitsha-otel

Conversation

@stephenlutar2-hash
Copy link
Copy Markdown
Member

Foundational fix — unblocks all open amaru PRs

Problem

tests/test_telemetry_and_health.py::test_healthz_includes_git_sha_and_otel_flag fails on main. This is the single failing required check ("Python sidecar — existing chakra tests") that blocks every open amaru PR (#105, #106, #107, and others).

The sidecar/src/amaru/version.py module already resolves GIT_SHA, GIT_SHA_SHORT, BOOT_TS, and telemetry.otel_active() already exists — but the /healthz handler in app.py never surfaced them. The test expects gitSha, gitShaShort, bootTs, and otel in the body.

Fix

Adds 4 keys to the /healthz JSON body, reusing the already-resolved values. Additive, zero-bandaid — no behavior change to chakras / scheduler / receipts.

+from . import telemetry as _telemetry
+from . import version as _version
...
     "version": __version__,
+    "gitSha": _version.GIT_SHA,
+    "gitShaShort": _version.GIT_SHA_SHORT,
+    "bootTs": _version.BOOT_TS,
+    "otel": _telemetry.otel_active(),

Verification

Reproduced the exact CI env (pip install -e ".[dev]", no opentelemetry) in a clean venv:

  • Before: test_healthz_includes_git_sha_and_otel_flag FAILED
  • After: 53 passed, 1 skipped — full tests/ suite green

Doctrine

Doctrine v11 (749/14/163 LOCKED). SLSA L1 (honest). No doctrine bump.

Sign: Yachay. Perplexity Computer Agent.

The version.py module (GIT_SHA, GIT_SHA_SHORT, BOOT_TS) and telemetry.otel_active()
already existed, but the /healthz handler never surfaced them. This left
tests/test_telemetry_and_health.py::test_healthz_includes_git_sha_and_otel_flag
failing on main, which blocked every open amaru PR's required 'Python sidecar —
existing chakra tests' check.

Additive, zero-bandaid: only adds 4 keys to the healthz JSON body, reusing the
existing resolved values. No behavior change to chakras/scheduler/receipts.

Verified in a clean CI-equivalent venv (.[dev], no otel): 53 passed, 1 skipped.

Doctrine v11 (749/14/163 LOCKED). SLSA L1.
Sign: Yachay. Perplexity Computer Agent.

Signed-off-by: stephenlutar2-hash <yachay@szlholdings.dev>
@stephenlutar2-hash stephenlutar2-hash merged commit b42ae80 into main Jun 1, 2026
12 checks passed
@stephenlutar2-hash stephenlutar2-hash deleted the fix/healthz-gitsha-otel branch June 1, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant