Fix --check and secret FP for 1.1.1 - #139
Merged
Merged
Conversation
Use a single bandit -r with multiple paths, and skip package __init__.py when mapping to pytest targets.
Ignore code and prose string fragments so f-string message pieces no longer trigger high-entropy secret hints.
Record the check and hint fixes in the changelog and update the external feedback checklist for --brief and Review quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--checkbandit invocation to use a single-rwith multiple paths__init__.pywhen mapping changed sources to pytest targetspossible_secrethigh-entropy detection so f-string/code fragments are ignoredTest plan
pytest— 280 passedruff check src testsmypy srcdiffrat review --range HEAD~1..HEAD --checkno longer fails withunrecognized argumentsortests/test___init__.py