Repository navigation
Add local macOS audio recording - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meetxt record <output.wav>as a separate macOS recording flowScope check
The implementation stays within issue #8: default-device WAV recording only. It does not add device selection, combined record/transcribe, Linux support, integrations, diarization, summaries, or cloud storage.
Validation
bundle exec rake— 47 examples pass; RuboCop reports no offensesgem build meetxt.gemspec— succeeds./scripts/check-workflow-leak.sh— cleangit diff --check— cleanA real microphone capture was not automated because it requires macOS hardware permission and interactive input. Automated tests cover command construction, native stop signaling, output publication, collisions, failed/empty capture cleanup, unsupported platforms, and missing FFmpeg.
Diff risk
Diff-risk: Medium
Signals: Architecture boundary / external-process change, cross-layer code + docs change
Evidence: 12 files add one recorder boundary, CLI dispatch, focused tests, and matching product documentation; no dependency, migration, CI, auth, or secret changes
Reviewer focus: FFmpeg AVFoundation command, Enter-to-stop process lifecycle, and exclusive temporary-to-final WAV publication
Required action: Manually smoke-test
meetxt record meeting.wavon macOS with microphone permission before releaseDependencies and follow-ups
PATHCloses #8