Repository navigation
Add first usable transcription CLI slice - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meetxtexecutablemeetxt transcribe <audio-file>from local validation through one OpenAI request to atomic Markdown outputwhisper-1verbose JSON segment handling in the OpenAI adapter, with SDK retries/logging disabled and sanitized error mappingCloses #6
Scope check
This is the first file-based transcription slice only. It does not add recording, diarization, summaries, integrations, retries, cloud storage, accounts, GUI behavior, or Linux-specific support.
Validation
bundle exec rake— 37 examples, 0 failures; 22 files linted with no offensesgem build meetxt.gemspec— builtmeetxt-0.1.0.gembash tests/test-adapter.sh— passedbash scripts/check-workflow-leak.sh— cleanbash scripts/ai-workflow-doctor.sh— readygit diff --check main...HEAD— cleanAutomated validation makes no paid OpenAI request. A manual smoke test exposed the verbose-response SDK shape mismatch addressed in the latest commit; the smoke test must be rerun manually.
Review notes
Independent integrated review identified SDK conversion-error sanitization and missing CLI validation/write-failure coverage. Both were fixed. A follow-up review of the real-response parsing fix was also clean: openai-ruby 0.80.0 preserves verbose-only fields behind its public raw-key accessor, while its multipart encoder correctly sends the bracketed timestamp array.
Diff-risk: Medium
Signals: architecture/API boundary, cross-layer application/CI/docs change, security-sensitive external upload and secret handling, new OpenAI SDK dependency, CI workflow change
Evidence: 33 scoped files establish the first complete CLI slice; provider behavior is isolated in
lib/meetxt/providers/openai_adapter.rb; 37 mocked/local examples cover request count, SDK response coercion and multipart encoding, sanitization, validation, rendering, CLI behavior, and atomic no-overwrite outputReviewer focus: OpenAI request/response mapping and error sanitization; hard-link-based atomic publication; CLI exit/output behavior
Required action: Human review and green CI before merge
Limitations and follow-ups
whisper-1withverbose_jsonsegment timestamps behind the adapter boundary.