Repository navigation
Conversation
Trust explicit UTC offsets when parsing recorded timestamps in the UI and saved state. Prevent crashes when server and browser timezone data disagree, such as Vancouver's permanent daylight saving time. Add regression tests for offset mismatches and countdown rendering.
Owner
|
Interesting bug. Thanks for the PR! (I wish my time stopped changing!) I will carve out some time soon to review and hopefully incorporate this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a blank web UI when the backend and browser have different timezone rules, such as Vancouver's switch to permanent daylight saving time. A timestamp with the old
-08:00offset and[America/Vancouver]annotation causes strict Temporal parsing to throw in a browser expecting-07:00.Validated with 25 targeted tests under both Bun and Node, production build, type-check, lint, and changed-file formatting. Also verified the production UI in-browser with the Vancouver offset mismatch: the countdown and cookie form render without errors. The repository-wide formatting check flags existing CRLF files on Windows; unrelated files were left untouched.