Conversation
|
Wow, what responsiveness! This new proposed version works very well! I was able to test it with the users of my FabLab, it works really well! Thank you ! EDIT : Going deeper into the tests, it seems that the bottom left move only works half the time. When this does not work, a "CSS implement" error appears. |
|
Sorry for the long delay, I was busy with other stuff :-) Looking at the code: My feeling is that we're slightly mixing up the interface boundaries. In an ideal solution, we would separate between
At least it would be nice to keep this y-shifting out of the individual image importers, or to the very least rename the method arguments from "originIsBottomLeft" to "placePageAtBottom" Regarding functionality, I'm still struggling to fully understand the use case. I don't think that the position of the origin is crucial. The origin is artificial and doesn't matter for how you use the lasercutter. Maybe the position of the physical "ruler" where you physically align your rectangular piece of material is more relevant: If your cutter only has that on bottom-left, then (without VisiCam camera view) you will prefer to push your material against that corner for repeatable positioning. |
mgmax
left a comment
There was a problem hiding this comment.
Needs discussion, see my previous comment from a long time ago
In #633 @LaFabrique35 suggests, that if the lasercutter has a bottom-left coordinate system, the files should be placed relative to the bottom left.
E.g. if you have this SVG:
example.zip
the rectangle is positioned x=20 and y=30 (relative to the bottom of the view box).
I started implementing this, but I have a few things to consider:
Binaries are at https://download.visicut.org/feature-633-import-bottom-left