Fix release version detection - #722
Merged
Merged
Conversation
jnweiger
reviewed
Apr 8, 2024
TheAssassin
force-pushed
the
fix-checkinstall
branch
from
April 8, 2024 13:03
6be8b52 to
6024808
Compare
Collaborator
|
Thanks for the improvement. I'm not sure if this really solves the root cause. We will probably have the same issue if someone clones and builds locally. Looks like GitHub releases is only intended for building "release" versions and not every single commit? |
Contributor
Author
|
People are indeed affected locally as well. This was specifically meant to "fix" the problem on the CI for now. I know that @jnweiger has had this problem locally once already. |
mgmax
added a commit
to mgmax/VisiCut
that referenced
this pull request
May 25, 2024
The old workaround is no longer needed, now that tthe issue has been proper fixed in b407646 Revert "Fix release version detection (t-oster#722)" This reverts commit 4054819.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix build issues like in #721.