This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Allow the passing of props and bumped dependency versions#54
Open
MikaelCarpenter wants to merge 81 commits into
Open
Allow the passing of props and bumped dependency versions#54MikaelCarpenter wants to merge 81 commits into
MikaelCarpenter wants to merge 81 commits into
Conversation
Author
|
@t4t5 :D also for anyone wanting to make these changes manually to their project. After updating the dependencies: |
Author
|
@JHabdas I haven't checked it out yet, but would you want to use it for the nav bar transitions rather than the opacity from tween-state? |
…without having to navigate
014f561 to
130500f
Compare
added this.props.replaceRoute()
Quick Border Fix
hideNavigationBar fix
added noStatusBar to <Router />
Changed resetToRoute to use a better navigator API Fixed some jslint warnings
Update index.js
Allow recent versions of react-native too!
React-native dependency version bump
Added docs for resetToRoute
removed drag stuff as per https://github.com/MikaelCarpenter/gb-native-router/pull/26/files
Adding resetToRoute API
Update README.md
Converting to ES-6 style, Implemented support for hiding the navbar per route Implemented support for an event emitter when a route is focused (useful when you want to know when you navigate back to a route) Fixed the missing closing tag intruduced in previous PR Fixed requires to be destructuring assignments instead
Added support for hiding navbar per route Style improvements
Styling improvements and fixing requires to be a destructuring assigmnent
Styling improvements
Adding docs for new features
Update index.js
Update NavBarContent.js
Update NavButton.js
Update README.md
fixed indent
Update NavBarContainer.js
Re-adding changes that got lost
adding lost code.. :(
Add RC versions to RN dependencies
Switching to facebook emitter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
props
Originally had to pass
dataobject and call it viathis.props.data.myPropwhich seems unnecessary.dependencies
If you had a recent version of react-native, you would get errors when running
npm startWhat
props
Instead of passing
datain your route, you can now passpassPropswhich takes in an object, and then creates a prop for eachkey: valuepair in the object.dependencies
Updated the version numbers in
package.jsondependencies.This is also an update to a previous PR (#47) by wenkesj
Issue
Props #39
Dependencies #53
Example
Your
Homecomponent can now usethis.props.prop1andthis.props.prop2