Repository navigation
CI на каждый PR + фикс падения проверки разрешения на API 26-28 - #2
Merged
Merged
Conversation
Добавлен workflow ci.yml: assembleDebug + lint на pull_request и push в main (release.yml остаётся только для тегов). Lint сразу поймал реальный баг — unsafeCheckOpNoThrow требует API 29, а minSdk = 26, поэтому на Android 8-9 проверка разрешения роняла бы приложение. - ci.yml: JDK 17, Android SDK, assembleDebug + lint, артефакт lint-отчёта - hasUsageStatsPermission: ветка по Build.VERSION.SDK_INT — unsafeCheckOpNoThrow на API 29+, checkOpNoThrow на 26-28 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Зачем
На PR #1 не появилось ни одной проверки: единственный workflow
release.ymlсрабатывает только по тегамv*. Этот PR добавляет CI, который собирает проект и гоняет lint на каждый pull request и push вmain.Что внутри
1. Новый workflow
.github/workflows/ci.ymlpull_requestиpushвmain../gradlew :app:assembleDebug lint.if: always()).release.yml).2. Фикс реального бага, который сразу поймал lint
hasUsageStatsPermissionвызывалAppOpsManager.unsafeCheckOpNoThrow, доступный только с API 29, тогда какminSdk = 26. На Android 8/8.1/9 это уронило бы приложение сNoSuchMethodErrorпри первой же проверке разрешения. Теперь:unsafeCheckOpNoThrowcheckOpNoThrow(deprecated, но корректный для этих версий)Проверка
./gradlew :app:assembleDebug lintлокально — BUILD SUCCESSFUL (остались только warnings, error-уровень устранён).🤖 Generated with Claude Code