Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @kinderhead we found some cross-compiler compatibility problems caused
by accidentally using gcc specific extensions, specially constexpr being used
where it does not really applies. I worked with him to get it to compile on MSVC
and updated the github actions to build and test to both MSVC and Clang in
addition to GCC we already were testing.
As removing constexpr is kind of a compatibility break, I bumped to 0.9.0 and
included other breaking change in my backlog, the complete list of changes are
bellow:
nullptrfrom "";just call SDL's version of these;
(removed the misleading
_PONTERprefix);?:;types width;