Skip to content

[TSK-178] - Supports GruppenMachen - #86

Merged
hugohvf merged 2 commits into
mainfrom
feat/supports-grouping
Dec 4, 2025
Merged

[TSK-178] - Supports GruppenMachen#86
hugohvf merged 2 commits into
mainfrom
feat/supports-grouping

Conversation

@hugohvf

@hugohvf hugohvf commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@hugohvf hugohvf self-assigned this Dec 1, 2025
@codecov-commenter

codecov-commenter commented Dec 1, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 59.38567% with 119 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
querymate/core/query_builder.py 42.00% 58 Missing ⚠️
querymate/core/querymate.py 57.33% 32 Missing ⚠️
querymate/core/grouping.py 73.87% 29 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hugohvf hugohvf changed the title Supports GruppenMachen [TSK-178] - Supports GruppenMachen Dec 3, 2025
@hugohvf
hugohvf requested review from a team and banduk December 3, 2025 21:34
querymate = Querymate(
select=["id", "name", "status"],
group_by="status",
limit=10,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this limit is applied to group by? If yes, i prefer having, wdyt?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having would make more sense but I using the same pagination interface as search for easier adaptability. As we don't need limit for both group as for the total there is no need to have a different nomenclature

Numeric Offset
~~~~~~~~~~~~~~

Use ``tz_offset`` to specify the offset in hours from UTC:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to split this things related to timezone in other PR.
And also, i would pass a timezone or function

@hugohvf
hugohvf merged commit c64c71f into main Dec 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants