feat(querymate): add join_type parameter for relationship queries - #88
Merged
Conversation
- Add join_type param to apply_select() and build() methods - Support 'inner' (default), 'left', and 'outer' join types - Left/outer joins include parent records with empty relationship lists - Export JoinType type alias from main module - Add comprehensive tests for all join type scenarios
rafaelrds
marked this pull request as ready for review
January 13, 2026 20:46
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
hugohvf
reviewed
Jan 14, 2026
hugohvf
left a comment
hugohvf
left a comment
Collaborator
There was a problem hiding this comment.
Algumas duvidas pontuais.
Vale adicionar exemplos na docs dele tbm pra referencia futura de como usar: https://github.com/talismanai/querymate/blob/5ac8d7382bb309f395bd9469b99047128113a932/docs/source/usage
|
Poderia adicionar um test case com valor inválido de "join-type"? |
boschi
approved these changes
Jan 14, 2026
banduk
approved these changes
Jan 14, 2026
hugohvf
reviewed
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adiciona parametro
join_typepara queries com relacionamentos.Por padrao usa INNER JOIN (comportamento atual). Com
join_type='left'ou'outer', usa LEFT OUTER JOIN para incluir registros pai mesmo quando nao existem filhos relacionados.Retrocompatibilidade garantida: queries antigas sem
join_typecontinuam usando INNER JOIN (default).Exemplo:
Testes adicionados para cobrir ambos os cenarios.