Add opt-in no-count pagination and window grouping - #90
Open
hugohvf wants to merge 3 commits into
Open
Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Summary
pagination.mode:fullremains the default and still runs the count query,nonefetches items only, andhas_nextfetcheslimit + 1then trims the extra row.groupingoptions forstrategy,include_counts,per_group_limit,per_group_offset, andfallback.fallbackiserror.Flow
flowchart TD A[Querymate request] --> B{pagination.mode} B -->|full default| C[Fetch page and run count] B -->|none| D[Fetch page only] B -->|has_next| E[Fetch limit plus one and trim] A --> F{grouping.strategy} F -->|legacy default| G[Group keys plus per-group item queries] F -->|window opt-in| H{Supported shape} H -->|yes| I[Single window query for top N per group] H -->|no, fallback legacy| G H -->|no, fallback error| J[Clear validation error]Tests
uv run --python 3.13 ruff check querymate testsuv run --python 3.13 mypy querymateuv run --python 3.13 pytest -q