Add button to save passport image to gallery#62
Open
stilktf wants to merge 1 commit into
Open
Conversation
Owner
|
What does it look like? |
|
FWIW, I built the change in this PR locally, merged with the latest head. Here's a screenshot (partially redacted) of how it looks like...
The fact that the layout with the photo is a bit wrong is a pre-existing issue, I think (I also had to add support for jp2, to be able to extract it). Keep in mind that, as it is, the photo will be capped to a height of 320. This is because the image is scaled down since I tried to remove the code that scales down, but the it crashes due to |
Owner
|
Maybe we can just have a icon button next to the image? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to save the image in the ImageView to gallery. It might need a snackbar or similar to remind the user the image was saved.
Tested on my phone and passport, it seems to work for me at least.
Fixes (#60)