Conversation
isabella
reviewed
Jan 27, 2026
| // External pointer: resolve to artifact ID. | ||
| let external_node = graph.nodes.get(&p.index).unwrap(); | ||
| external_node.artifact.as_ref().map_or_else( | ||
| || edge.clone(), |
Member
There was a problem hiding this comment.
this falls back to the case that caused the bug where edge has the pointer to the index, we should explicitly error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing packages from different entry points produced different IDs for the same package (e.g., tg publish std then tg publish jq would give std different IDs).
Root causes:
outside the SCC) retained ephemeral checkin graph indices instead of resolved object IDs. These indices differ based on entry point.
Fix: