Skip to content

Fix deletion #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanin47 merged 1 commit into from
Jan 24, 2026
Merged

Fix deletion #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions frontend/svelte/_delete_modal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script lang="ts">

import {Sheet} from "./common/models"
import {type Filter, type FilterOperator, Sheet} from "./common/models"
import {type FetchError, post} from "./common/form"
import Button from './common/_button.svelte'
import ErrorPanel from "./common/form/_error_panel.svelte"
Expand All @@ -11,7 +11,7 @@ export let onDeleted: (rowIndex: number) => void

let modal: HTMLDialogElement;

let primaryKeys: Array<{ name: string, value: any }> = []
let primaryKeys: Array<Filter> = []
let rowIndex_: number | null = null

let isLoading = false
Expand All @@ -26,7 +26,11 @@ export function open(rowValues: any[], rowIndex: number): void {
.map((column, index) => {
if (column.isPrimaryKey) {
const value = rowValues[index];
return {name: column.name, value: value === null ? null : ('' + value)}
return {
name: column.name,
value: '' + value,
operator: (value === null ? 'IS_NULL' : 'EQUAL') as FilterOperator
}
} else {
return null
}
Expand Down Expand Up @@ -93,7 +97,7 @@ async function submit(): Promise<void> {
<span>Primary key:</span>
{#each primaryKeys as pair (pair.name)}
<code>
{pair.name} = {pair.value ?? 'NULL'}
{pair.name} = {pair.operator === 'IS_NULL' ? 'NULL' : pair.value}
</code>
{/each}
</div>
Expand Down
Loading