Add ROCm / AMD Instinct MI300x support#17
Open
subhajitdchow wants to merge 20 commits into
Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Subhajitdchow/add governance docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds AMD Instinct MI300x support via ROCm 7.2, PyTorch 2.9.1, FlashInfer v0.5.3+amd.2, and CK-backend flash-attn (pinned to 0f82fea).
NVIDIA path is unchanged — all new logic is gated on
torch.version.hip.What's included
setup_rocm.sh— one-command ROCm setup inside FlashInfer Docker containerssd/layers/flash_attn_compat.py— SDPA fallback when native flash-attn unavailablesgl_kernelon NVIDIA,flash_attn/SDPA on AMD)SSD_TREE_DECODE_BACKEND={flashinfer,sdpa}plan()args and default CUDA archrope_scalingfix,return_dict=Falsefor newer transformersValidation
70B target + 1B draft, 5× MI300x: ~225.86 tok/s (4.32× AR, 1.64× SD) across alpaca / c4 / ultrafeedback / humaneval.