Repository navigation
Conversation
0.3.1 changed applyCode to Result and broke 0.3.0 source compatibility. Restore the (JSONObject) -> Unit overload as @deprecated; on failure it throws TapAppLinkRedeemException and never delivers an error body as success. Keep the Result API (@JvmName applyCodeWithResult). Android apps should upgrade to 0.3.2. Co-authored-by: Kenny Ye <KennyYe@users.noreply.github.com>
Explicit Result<JSONObject> parameter matches the restored dual overloads. Co-authored-by: Kenny Ye <KennyYe@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to 0.3.2. 0.3.1 changed
applyCodeto(Result<JSONObject>) -> Unit, which broke source compatibility for apps on 0.3.0.applyCode(code, callback: (JSONObject) -> Unit)as@Deprecated.TapAppLinkRedeemExceptionon the worker thread and never delivers an error body as success (0.3.0 had no error callback).ResultAPI (@JvmName("applyCodeWithResult")for JVM erasure).Test plan
./gradlew test ktlintCheck lintReleasev0.3.2, confirm Release workflow