Repository navigation
SDK 0.3.2: redeem requestId for applyCode retries - #6
Merged
Merged
Conversation
Persist a UUID requestId per normalised code attempt and reuse it on network/timeout retries (including after restart). Clear it on 2xx or typed unknown/inactive/wrongEnvironment responses. Additive only; applyCode Result signature unchanged. Co-authored-by: Kenny Ye <KennyYe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additive 0.3.2 fix:
applyCodesends a persistentrequestIdon/redeemCodeso the server can recognise retries after a timeout and avoid double-counting an install.applyCode(code) { result: Result<JSONObject> -> }signature unchanged (no new overloads).requestIdper normalised code (uppercase, strip non-alphanumerics, max 24); reuse until a definitive response (2xx or typed unknown/inactive/wrongEnvironment); persist with install-state storage.SDK_VERSION/X-TapAppLink-SDK-Versionbumped to0.3.2.applyCodeafter a timeout could count an install twice. 0.3.2 sends a request ID so the server recognises the retry. No code changes needed.Do not merge or tag yet (release hold).
Test plan
./gradlew test ktlintCheck lintReleasev0.3.2tag until directed