Repository navigation
Fix applyCode typed redeem errors (0.3.1) - #3
Merged
Merged
Conversation
Check HTTP status on every request, map redeem failures to TapAppLinkRedeemError, send X-TapAppLink-SDK-Version, and document customer UI states for each result. Co-authored-by: Kenny Ye <KennyYe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React Native 0.3.0 could treat a non-2xx
/redeemCodebody as a successfulapplyCode()result. This release checks HTTP status on every request, raisesTapAppLinkRedeemErrorfor redeem failures, and sendsX-TapAppLink-SDK-Version: 0.3.1.Changes
TapAppLinkRedeemErrorwith codes:unknownCode,inactiveCode,wrongEnvironment,network,othererror(unknown_code,inactive_code,wrong_environment) with status fallbacks (404 / 410 / 400)Upgrade note
Upgrade to 0.3.1 so
applyCode()raises a typed error instead of returning error JSON as success.Test plan
npm test(including redeem error cases)npm run typecheck/lint/buildv0.3.1and confirm release workflow publishes