replace usleep() with nanosleep() in msleep(), add a missing default case in getkey() #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add default case in ASCII character processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usleep()has been removed in POSIX 2008, C code that includesrlutil.hwill not compile if_POSIX_C_SOURCEis set to200809Lor greater.nanosleep()fromtime.his a suggested alternative and compiles successfully whether the POSIX standard is set or not.Also, a default case has been missing in
getkey()in the switch case for processing ASCII escapes.Not having a default case also causes C code to not compile when universally appropriate warning flags are turned on with gcc.
I set the default case to return -1, but there might be a better alternative (if maybe a #define to -1 somewhere for code readability).