Conversation
Small UX improvements - `autocomplete: "one-time-code"` allows browsers like Safari to automatically suggest OTPs received in SMS and emails. https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#sect16 - `autofocus: true` opens the virtual keyboard automatically on mobile, and helps keyboard users on desktop too - `pattern: [a-z0-9]` allows browsers to adapt the virtual keyboard on mobile, and to validate before sending the form on mobile and desktop. You could even go the extra mile and add a stimulus controller to strip whitespace, in case the user copies spaces or newlines along with the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small UX improvements
autocomplete: "one-time-code"allows browsers like Safari to automatically suggest OTPs received in SMS and emails. https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#sect16autofocus: trueopens the virtual keyboard automatically on mobile, and helps keyboard users on desktop toopattern: [a-z0-9]allows browsers to adapt the virtual keyboard on mobile, and to validate before sending the form on mobile and desktop.You could even go the extra mile and add a stimulus controller to strip whitespace, in case the user copies spaces or newlines along with the code.
In know this repo is only for demo purpose, but thought I'd share these quick UX wins antway because we'd all be better off if all devs knew about them :-)