fix: pin next.js to 16.1.7 to mitigate CVE risk (closes #103)#104
fix: pin next.js to 16.1.7 to mitigate CVE risk (closes #103)#104Ojas2095 wants to merge 2 commits into
Conversation
…t#103) - Changed ext from ^16.1.1 to 16.1.7 (exact pin, no caret) - Changed eslint-config-next from ^16.1.1 to 16.1.7 (exact match) - Prevents npm/yarn from resolving to any CVE-affected patch/minor releases - Regenerate lock file to reflect exact pinned resolution
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
There was a problem hiding this comment.
Code Review
This pull request updates the versions of next and eslint-config-next in package.json. However, the specified version 16.1.7 does not exist on the npm registry. Feedback was provided to use version 15.1.7 for both packages to ensure compatibility with React 19 and successful dependency resolution.
| "i18next-http-backend": "^3.0.2", | ||
| "motion": "^12.26.2", | ||
| "next": "^16.1.1", | ||
| "next": "16.1.7", |
There was a problem hiding this comment.
The version 16.1.7 for the next package does not exist on the public npm registry. The current latest stable version is 15.1.7. Although the previous version was listed as ^16.1.1, that version also does not exist. Using a non-existent version will cause installation and build failures. Given the project's use of React 19 (as seen in lines 26-27), Next.js 15 is the appropriate major version to use.
| "next": "16.1.7", | |
| "next": "15.1.7", |
| "@walletconnect/ethereum-provider": "^2.23.2", | ||
| "eslint": "^9.39.2", | ||
| "eslint-config-next": "^16.1.1", | ||
| "eslint-config-next": "16.1.7", |
There was a problem hiding this comment.
|
Both suggestions above from gemini aren't valid.
|
Closes #103
Pins next and eslint-config-next to exact version 16.1.7 (no caret) to mitigate known CVEs.
This prevents npm/yarn from resolving to any CVE-affected patch/minor releases.