fix(snd): replace legacy blue cloud on expired-link screen with Vault hero#25
Merged
Conversation
… hero app/ui/notFound.js (rendered when a share link has expired or 404s) was still using assets/notFound.svg -- a Mozilla Firefox Send-era illustration: saturated blue, soft cloud-with-strike-through glyph, decorative. Same off-brand carryover that downloadCompleted.js had before PR #18 fixed it. Replacement uses the existing Vault visual vocabulary, mirroring the download-complete hero from PR #18 so the encrypt/decrypt/expired moments visually rhyme: - Three nested squares (concentric, hairline outer pair). - Inner square in `--snd-mute` (not danger -- expired is not a destructive condition, it's an absent one). - Diagonal slash from corner to corner of the inner square, in mute. - EXPIRED tag eyebrow above the headline. - A `>`-prefixed mono caption -- "share no longer available · file removed from server" -- echoing the Vault comment-line motif. assets/notFound.svg is no longer referenced. Leaving the file in place for now; webpack still emits it but no template loads it. The `assets` import is also dropped since it's no longer used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
`app/ui/notFound.js` (rendered when a share link has expired or 404s) was still using `assets/notFound.svg` — a Mozilla Firefox Send-era illustration: saturated blue, soft cloud-with-strike-through glyph, decorative. Same off-brand carryover that `downloadCompleted.js` had before PR #18 fixed it.
Visual
>-prefixed mono captionThe replacement mirrors the download-complete hero from #18 so the encrypt / decrypt / expired moments visually rhyme — same three-nested-square primitive, different inner glyph and color to communicate state:
`mute` chosen over `danger` deliberately — expired is an absent condition (file is gone, no recovery), not a destructive one warranting the terracotta danger color reserved for "delete share" / "attempt-exceeded" per the spec.
Other cleanup
Test plan
/dl/<garbage>) and confirm the new hero renders