ci: add security scanning and test coverage for the public repo - #23
Merged
Merged
Conversation
- CodeQL workflow (javascript-typescript + actions, weekly schedule) - dependency-review job blocking PRs that add vulnerable dependencies - CODEOWNERS so the ruleset's code-owner review requirement is enforced - SECURITY.md pointing reporters at private vulnerability reporting - dependabot npm ecosystem (weekly, minor/patch grouped) - vitest v8 coverage: test:coverage script, CI step summary, report artifact; vitest.workspace.ts migrated to vitest.config.ts (workspace file is deprecated in vitest 3.2, and coverage config lives at the root)
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Replaces the coverage-report artifact with actions/upload-code-coverage, which feeds GitHub's built-in coverage UI; vitest now also emits a cobertura report for it.
- unit and component tests run separately again, each with coverage scoped to the layer it exercises, uploaded under its own label - coverage upload is blocking again (fail-on-error default) - step-summary coverage table removed; GitHub's coverage UI replaces it - codeql.yml removed in favor of GitHub's built-in default setup - CODEOWNERS narrowed to @titan-ron
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/unitThe overall coverage in commit c7f247b in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/componentThe overall coverage in commit c7f247b in the Show a code coverage summary of the most covered files.
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the repo is public, wire up the free security features that can live in the repo itself, plus code coverage.
Security
javascript-typescript+actionsmatrix, PRs + main + weekly schedule), pinned tov4.37.6@titan-ron @matansocher @amitbreuer) — the branch ruleset already requires code-owner review, which was a no-op without this fileCoverage
npm run test:coverageruns both vitest tiers with v8 coverage oversrc/**vitest.workspace.tsmigrated tovitest.config.tswithtest.projects(the workspace file is deprecated in vitest 3.2, and coverage config lives at the root). Baseline: 36.9% lines / 74.7% branches across 92 tests.Validation
npm run typecheckcleannpm run test:coverage— 92/92 tests pass, coverage report generatedFollow-up (settings, not PR-able): enable private vulnerability reporting, add
cias a required status check on the ruleset.