fix: handle multi-word translations in German extractor#1608
Open
johnny wants to merge 1 commit intotatuylonen:masterfrom
Open
fix: handle multi-word translations in German extractor#1608johnny wants to merge 1 commit intotatuylonen:masterfrom
johnny wants to merge 1 commit intotatuylonen:masterfrom
Conversation
Multi-word translations like {{Ü|fr|temps}} de {{Ü|fr|travail}} were
being split into two separate entries ('temps' and 'travail') instead
of being combined into 'temps de travail'.
Two changes:
- Plain text between Ü templates (e.g. 'de') is now concatenated to
the current word instead of being silently dropped.
- Consecutive Ü templates with the same lang_code append their words
to form a single multi-word translation, while different lang_codes
still trigger a new translation entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-word translations like {{Ü|fr|temps}} de {{Ü|fr|travail}} were being split into two separate entries ('temps' and 'travail') instead of being combined into 'temps de travail'.
Two changes: