[ja] Support ja-kanji template extraction#1616
Open
daxida wants to merge 1 commit intotatuylonen:masterfrom
Open
[ja] Support ja-kanji template extraction#1616daxida wants to merge 1 commit intotatuylonen:masterfrom
ja-kanji template extraction#1616daxida wants to merge 1 commit intotatuylonen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1587
It doesn't parse every argument, but most of what I consider to be of value. It can always be easily tweaked in the future to be more precise but from what I could test it worked fine.
For @xxyzz , does the extraction of the template happen at the right place, or should I have put it somewhere else. I mean the changes in
src/wiktextract/extractor/ja/page.py:It usually happens at this level in Wiktionary:
https://ja.wiktionary.org/wiki/韻#日本語
For everyone, should I have used a
Forminstead ofSound, since it is mostly a string and some tags? Much like transliterations are forms with thetransliterationtag. I even had aKanjiReadingclass at some point, but it was pretty much a simplerForm.