[en] INCOMPLETE WIP TRASH-HEAP DO NOT LOOK AT ME try to extract links from heads to attach to forms#1617
Open
kristian-clausal wants to merge 3 commits intomasterfrom
Open
[en] INCOMPLETE WIP TRASH-HEAP DO NOT LOOK AT ME try to extract links from heads to attach to forms#1617kristian-clausal wants to merge 3 commits intomasterfrom
kristian-clausal wants to merge 3 commits intomasterfrom
Conversation
Gets links and categories (if provided with `category_ns_names`)
and returns a list of tuples `[(text, link), ...]` and category
names `{name, ...}`.
Changes to these to enable some kludges later. There was a kludge here that checked if the word had special characters and then checked the links in the head to use them in various places, like a splitting regex and other places where the head text is split, and some of the code was shuffled from the higher level function to the lower. There will follow a commit that wants to use more `links` data, so we generated a `links` list using the new `extract_links_from_nodes()` helper function (also changed a bit) that may be used later. But if it is not generated here, it will be later, which is why `links` is an Optional to check whether it is None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am going on a break next week for two weeks and I've been hitting my head against this for too gd long and I am putting this here only to remind me of my shame when I get back so that I will pick it up again.