Run PR checks on stacked pull requests too - #74
Merged
Conversation
`on: pull_request: branches: [master]` only triggers for PRs whose *base* is master, so a PR stacked on another PR silently ran no checks at all. That is the PR most in need of them, since it is reviewed against a base that has not landed yet. Verified against PR #73, which targets a feature branch: "no checks reported on the 'fix/import-data-loss' branch". ci.yml still handles push-to-master, so this does not double up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f0df23dc-ed73-4b56-9b7c-4d2846ddf2a2
taurheim
force-pushed
the
ci/require-checks-on-all-prs
branch
from
July 27, 2026 01:35
fe447dc to
006c0a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr.ymlwas scoped toon: pull_request: branches: [master], which only fires when the PR's base is master. A PR stacked on another PR therefore ran no checks at all:That is the PR most in need of checks, since it is being reviewed against a base that has not landed yet.
Dropping the filter makes the workflow run on every pull request regardless of base.
ci.ymlstill covers push-to-master, so this does not double up.Also done outside this repo
The
Protect master - require pull requestsruleset required a PR but had norequired_status_checksrule, so master could be merged into with CI red or CI never having run. I added it:Lint,Build,E2E Tests(pinned to the GitHub Actions app, so another integration cannot report a passing check with the same name)Note the interaction with stacked PRs: with the strict policy, each merge into master makes every other open PR need an update before it can merge.