chore(deps): update NAPI to v3#983
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Package Changes Through 4ff8daeThere are 2 changes which include create-tauri-app with patch, create-tauri-app-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
in tauri we reverted back to 3.0 but can't remember why |
|
The revert happened in tauri-apps/tauri#15310, I don't quite get what lucas meant though |
|
ah yeah. The docker containers have rust versions that are too old for napi 3.5+ since they raised the msrv to 1.88 we could switch containers or build our own but i don't think it's worth the trouble. i sure hope they'll update them soon but then again the issue is open since march last year... |
|
It seems like their demo project no longer uses the docker to build anymore, I could try switching to that tomorrow. And another thing, it seems like if we're using NAPI 3, the rust-version must be bumped to 1.81 for 3.0.0 and 1.88 for current latest. Considering we were publishing through latest stable rust, it should be fine to bump? |
Ahh they're using zigbuild for musl as well. I actually meant to use that for the gnu builds (in tauri as well) a while ago because of github's high glibc version.
Maybe after the next release? I'd like to have a working version first before we start with experiments :D
Yes, if we do not use their docker containers anymore it's fine since this is not the main crate. |
|
It seems like we even had setup-zig in our workflow just didn't use cargo-zigbuild. I'm gonna trigger the new release now, this one can wait. |
|
Well, that didn't really work either 🤦♂️
|
FabianLars
left a comment
There was a problem hiding this comment.
Are we using something that wasn't part of the 3.0.0 packages? Maybe it makes sense to write the current latest versions in cargo.toml/package.json just to be safe?
Don't care too much about it so approved either way
|
I don't think we do, the code were not even different from v2 |
Closes #913
Closes #914
Closes #970