fix(windows): dangling pointer when remove_for_hwnd called before drop#363
Merged
Conversation
Contributor
Package Changes Through de615bcThere are 1 changes which include muda with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
FabianLars
approved these changes
Jun 17, 2026
Legend-Master
commented
Jun 17, 2026
| "muda": patch | ||
| --- | ||
|
|
||
| On Windows, fixed a bug that would truncate menubar items text to ~10 characters in dark-mode. |
Contributor
Author
There was a problem hiding this comment.
I swear I wrote the change file and it didn't look like this 🤦♂️
Legend-Master
added a commit
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tauri-apps/tauri#15523
Spent so much time tracking this one down, the problem in tauri-apps/tauri#15523 was not that the menu getting accessed off main thread but simply the drop orders
A simpler reproduction tauri code is just
The problem here is that we didn't clean up the window subclass when removing the menu (the drop didn't clean it up because the tracking hwnd is removed by
remove_for_hwnd) and also we didn't refresh it in time that we calledSetMenubeforeSetWindowSubclassininit_for_hwnd_with_theme, andSetMenutriggeredmenu_subclass_procwhich contains the staleMenupointersorry about the push to dev branch by accident