Skip to content

fix(windows): Windows tray context menu can appear behind the taskbar after launching from Start Menu (#303) #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amrbashir merged 2 commits into from
Apr 30, 2026
Merged

fix(windows): Windows tray context menu can appear behind the taskbar after launching from Start Menu (#303) #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99fba05
fix(windows): Windows tray context menu can appear behind the taskbar…
Fullzoon Apr 27, 2026
a1cb0f0
chore: add change file for windows tray menu fix
Fullzoon Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/windows-tray-menu-zorder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"tray-icon": patch
---

Fixed a Windows tray menu issue reported in #303 where the context menu could appear behind the taskbar after launching from the Start Menu by aligning the tray menu handling with the expected shell behavior, including showing the right-click menu on button release and posting `WM_NULL` after `TrackPopupMenu`.
22 changes: 13 additions & 9 deletions src/platform_impl/windows/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@ use windows_sys::{
},
WindowsAndMessaging::{
ChangeWindowMessageFilterEx, CreateWindowExW, DefWindowProcW, DestroyWindow,
GetCursorPos, KillTimer, RegisterClassW, RegisterWindowMessageA, SendMessageW,
SetForegroundWindow, SetTimer, TrackPopupMenu, CREATESTRUCTW, CW_USEDEFAULT,
GWL_USERDATA, HICON, HMENU, MSGFLT_ALLOW, TPM_BOTTOMALIGN, TPM_LEFTALIGN,
WM_CREATE, WM_DESTROY, WM_LBUTTONDBLCLK, WM_LBUTTONDOWN, WM_LBUTTONUP,
WM_MBUTTONDBLCLK, WM_MBUTTONDOWN, WM_MBUTTONUP, WM_MOUSEMOVE, WM_NCCREATE,
WM_RBUTTONDBLCLK, WM_RBUTTONDOWN, WM_RBUTTONUP, WM_TIMER, WNDCLASSW, WS_EX_LAYERED,
WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW, WS_EX_TRANSPARENT, WS_OVERLAPPED,
GetCursorPos, KillTimer, PostMessageW, RegisterClassW, RegisterWindowMessageA,
SendMessageW, SetForegroundWindow, SetTimer, TrackPopupMenu, CREATESTRUCTW,
CW_USEDEFAULT, GWL_USERDATA, HICON, HMENU, MSGFLT_ALLOW, TPM_BOTTOMALIGN,
TPM_LEFTALIGN, WM_CREATE, WM_DESTROY, WM_LBUTTONDBLCLK, WM_LBUTTONDOWN,
WM_LBUTTONUP, WM_MBUTTONDBLCLK, WM_MBUTTONDOWN, WM_MBUTTONUP, WM_MOUSEMOVE,
WM_NCCREATE, WM_NULL, WM_RBUTTONDBLCLK, WM_RBUTTONDOWN, WM_RBUTTONUP, WM_TIMER,
WNDCLASSW, WS_EX_LAYERED, WS_EX_NOACTIVATE, WS_EX_TOOLWINDOW, WS_EX_TRANSPARENT,
WS_OVERLAPPED,
},
},
},
Expand Down Expand Up @@ -487,8 +488,8 @@ unsafe extern "system" fn tray_proc(

TrayIconEvent::send(event);

if (userdata.menu_on_right_click && lparam as u32 == WM_RBUTTONDOWN)
|| (userdata.menu_on_left_click && lparam as u32 == WM_LBUTTONDOWN)
if (userdata.menu_on_right_click && lparam as u32 == WM_RBUTTONUP)
|| (userdata.menu_on_left_click && lparam as u32 == WM_LBUTTONUP)
{
if let Some(menu) = userdata.hpopupmenu {
show_tray_menu(hwnd, menu, cursor.x, cursor.y);
Expand Down Expand Up @@ -551,6 +552,9 @@ unsafe fn show_tray_menu(hwnd: HWND, menu: HMENU, x: i32, y: i32) {
hwnd,
std::ptr::null_mut(),
);
// The shell docs recommend posting a benign message after TrackPopupMenu
// for notification area menus so the task switch is finalized correctly.
PostMessageW(hwnd, WM_NULL, 0, 0);
}

#[inline]
Expand Down
Loading