only run when python files changed, update docs - #8
Open
valentijnscholten wants to merge 17 commits into
Open
valentijnscholten wants to merge 17 commits into
valentijnscholten wants to merge 17 commits into
Conversation
Author
Author
|
this PR was meant for my own fork, but github defaults to the parent repo apparently so I'll just leave it here. |
only run when python files changed, update docs
|
@valentijnscholten I'm currently on your fork as it solves this problem. Thanks a lot for that. Maybe it is an idea to create a pull request containing the fixes you made on your master branch such that they are solved in the upstream repository? |
Author
|
I've merged my master into this branch. Not really production ready, due to the debug logging but it's a start. |
|
@valentijnscholten Thanks a lot! I will base my action on your branch for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the check was failing if there were no python files changed by the PR
also the docs were still referring to the old
main.workflowdefinitions from GitHub actions early days