Repository navigation
fix: bind OOB findings to the probe callback token - #61
Merged
Merged
Conversation
tayfuryldz
requested changes
Oct 2, 2026
tayfuryldz
left a comment
Owner
There was a problem hiding this comment.
The functional tests pass, but this branch still fails the repository Ruff gate. tests/test_oob.py has two unused imports: json and BaseHTTPRequestHandler. Please remove those and push the cleanup; I will re-run the full suite after that.
Contributor
Author
|
For sure I'm on it |
Ymax27
commented
Oct 2, 2026
Ymax27
left a comment
Contributor
Author
There was a problem hiding this comment.
Unnecessary imports removed
tayfuryldz
approved these changes
Oct 2, 2026
tayfuryldz
left a comment
Owner
There was a problem hiding this comment.
Thanks, the cleanup fixes the lint issue. I reran the branch against current main: Ruff and mypy are clean, the full test suite passes (122 passed, 3 skipped), and git diff --check is clean.
tayfuryldz
enabled auto-merge (squash)
October 2, 2026 17:37
Promote a blind callback only when the event token and protocol match the probe, and keep the stored callback evidence limited to that correlation. Co-authored-by: Cursor <cursoragent@cursor.com>
tayfuryldz
force-pushed
the
ymax27/fix-oob-callback-token
branch
from
October 2, 2026 17:37
e923d57 to
01432ce
Compare
Contributor
Author
|
You're welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpordns.query_events()applies that filter, andanalyze_oob_header_probe()derivesoob_confirmedfrom the validated events rather thanbool(events).tokenandprotocolonly, so source addresses and free-form detail are not persisted.Scope
Fixes #36.
This does not weaken the gate to a warning. An unrelated callback cannot satisfy another probe, including when it is returned from
/api/events/<expected-token>.Validation
Commands run on this branch:
Observed result: 5 passed.
ruffandmypyare not installed in this environment, so those gates were not run. The detector/evidence coverage gate was also not run here.Checklist
Made with Cursor